On 2020/01/24 00:19, Ingo Schwarze wrote:
> Hi,
> 
> Stuart Henderson wrote on Thu, Jan 23, 2020 at 11:26:12AM +0000:
> > On 2020/01/22 23:34, Raymond E. Pasco wrote:
> 
> >> Having looked at it a bit more, I see other statically linked ports with
> >> empty WANTLIB (e.g. shells/tcsh), but that doesn't necessarily mean it's
> >> correct. Since I don't know, here's another tgz identical to the last
> >> but with WANTLIB=c (which, if you remove -static, is what it would
> >> require).
> 
> > Please don't statically link it. The few ports doing this are special cases.
> 
> OK, here we go, with the following changes to what Raymond sent:
> 
>  * Delete -static from LDFLAGS in the Makefile.
>    I found no way to feed that in via the environment,
>    so i patched the Makefile.
> 
>  * Polish the COMMENT.  Saying just "generator" is not helpful
>    because it doesn't say from which source format, and this is
>    particularly relevant here because it uses an extremely unusual
>    format that nothing else uses, so the claim "generator" is overly
>    broad.  Also make it clear that generating man pages actually
>    means generating old 1979-style man(7) code.
> 
>  * Polish DESCR in the same vein.  POSIX is irrelevant here;
>    were are writing a decsription for OpenBSD.
> 
> 
> Obviously, this is only yet another low-quality man(7) generator
> (emitting pointless low-level roff(7) code, lots of bogus .P,
> incorrectly encoded dashes, using low-level font escapes rather
> than proper man(7) macros, failing to properly generate .MT
> and .UR, ... - and that's just from inspecting the thirty line
> file scdoc.1 itself) so using it certainly isn't encouraged.
> 
> But given that some people use it anyway for documentating their
> software, i agree that a port is needed, even if only as a dependency
> for other, potentially more useful ports.
> 
> OK?
>   Ingo


Add this, and it's OK sthen:

MAKE_FLAGS =            CC="${CC}"

Reply via email to