Hi,

At the end of this mail, Joerg's diff with plist regenerated.

On Tue, Jan 28, 2020 at 05:04:59AM +0000, Mikolaj Kucharski wrote:
> Hi,
> 
> I didn't test your diff Joerg, but by creating that log file on my end
> made kcaldav work, so from your below list of options, I like the most
> disabling the logfile.
> 
> On Fri, Jan 24, 2020 at 10:07:08PM +0100, Joerg Jung wrote:
> > Hi,
> > 
> > following the package README from kcaldav in a -current vanilla setup
> > just results in silent error responses (HTTP 505), as reported earlier
> > already [1].
> > 
> > I belive this happens because of LOGFILE define pointing to chroot
> > /var/www/logs/kcaldav-system.log, but httpd user/slowcgi has no write
> > access there by default, so the LOGFILE will not be created and
> > kcgi/kcaldav just fails.  Multiple options to resolve this:
> > 
> >    1. Tell users in README to do something like
> >       doas touch /var/www/logs/kcaldav-system.log
> >       doas chown www /var/www/logs/kcaldav-system.log
> >  
> >    2. Add a PLIST entry to auto-create /var/www/logs/kcaldav-system.log
> >       with the correct rights
> > 
> >    3. Disable the LOGFILE completely (reverting back to earlier port 
> >       versions behaviour), leaving normal stderr logging ending up in
> >       configured web servers error.log 
> > 
> > Attached is a diff for option 3.
> > 
> > OK?
> > 
> > Thanks,
> > Regards,
> > Joerg
> > 
> > [1] https://marc.info/?l=openbsd-ports&m=155082287919154&w=2
> > 
> > 


Index: Makefile
===================================================================
RCS file: /cvs/ports/www/kcaldav/Makefile,v
retrieving revision 1.16
diff -u -p -u -r1.16 Makefile
--- Makefile    17 Nov 2019 09:28:23 -0000      1.16
+++ Makefile    28 Jan 2020 06:21:45 -0000
@@ -3,6 +3,7 @@
 COMMENT =              a simple, safe, and minimal CalDAV server
 
 DISTNAME =             kcaldav-0.1.11
+REVISION =             0
 CATEGORIES =           www
 
 HOMEPAGE =             https://kristaps.bsd.lv/kcaldav/
Index: patches/patch-Makefile
===================================================================
RCS file: /cvs/ports/www/kcaldav/patches/patch-Makefile,v
retrieving revision 1.5
diff -u -p -u -r1.5 patch-Makefile
--- patches/patch-Makefile      17 Nov 2019 09:28:23 -0000      1.5
+++ patches/patch-Makefile      28 Jan 2020 06:21:45 -0000
@@ -14,3 +14,12 @@ Index: Makefile
  
  # File-system directory where "installwww" installs.
  # You probably aren't going to use that!
+@@ -150,7 +150,7 @@ VERSION             = 0.1.11
+ CFLAGS                += -DCALDIR=\"$(CALDIR)\"
+ CFLAGS                += -DHTDOCS=\"$(HTDOCS)\"
+ CFLAGS                += -DVERSION=\"$(VERSION)\"
+-CFLAGS                += -DLOGFILE=\"$(LOGFILE)\"
++#CFLAGS               += -DLOGFILE=\"$(LOGFILE)\"
+ BHTMLS                 = collection.html \
+                  home.html
+ DOTFLAGS       = -h "BGCOLOR=\"red\"" \
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/www/kcaldav/pkg/PLIST,v
retrieving revision 1.4
diff -u -p -u -r1.4 PLIST
--- pkg/PLIST   17 Nov 2019 09:28:23 -0000      1.4
+++ pkg/PLIST   28 Jan 2020 06:21:45 -0000
@@ -1,7 +1,7 @@
 @comment $OpenBSD: PLIST,v 1.4 2019/11/17 09:28:23 stsp Exp $
 @bin bin/kcaldav.passwd
 include/libkcaldav.h
-lib/libkcaldav.a
+@static-lib lib/libkcaldav.a
 @man man/man1/kcaldav.passwd.1
 @man man/man3/libkcaldav.3
 @man man/man8/kcaldav.8

-- 
Regards,
 Mikolaj

Reply via email to