On Wed, Jan 29, 2020 at 02:38:59AM +0100, Charlene Wendling wrote: > Hi, > > > http://build-failures.rhaalovely.net/sparc64/2020-01-26/security/ophcrack.log > (and in the current powerpc bulk) > > In ${WRKSRC}/src/samdump2/samdump2.c:44, a bundled bswap.h is #include'd > when built on big endian archs, pulling itself the generated > ${WRKSRC}/config.h, and that one is not in the include path.
> The below diff fixes that on powerpc [0]. While here an unrelated patch > has been regenerated. It still builds fine on amd64, including the > Qt5 GUI. > Comments/feedback are welcome, > Charlène. > [0] https://bin.charlenew.xyz/ophcrack.log Fixes the build on my sparc64 test machine. ok kmos > Index: Makefile > =================================================================== > RCS file: /cvs/ports/security/ophcrack/Makefile,v > retrieving revision 1.17 > diff -u -p -u -p -r1.17 Makefile > --- Makefile 16 Jan 2020 07:40:29 -0000 1.17 > +++ Makefile 29 Jan 2020 01:31:40 -0000 > @@ -3,6 +3,7 @@ > COMMENT = password cracker based on rainbow tables > > DISTNAME = ophcrack-3.8.0 > +REVISION = 0 > CATEGORIES = security > > HOMEPAGE = http://ophcrack.sourceforge.net/ > Index: patches/patch-src_gui_main_cpp > =================================================================== > RCS file: /cvs/ports/security/ophcrack/patches/patch-src_gui_main_cpp,v > retrieving revision 1.2 > diff -u -p -u -p -r1.2 patch-src_gui_main_cpp > --- patches/patch-src_gui_main_cpp 7 Jun 2013 10:03:27 -0000 1.2 > +++ patches/patch-src_gui_main_cpp 29 Jan 2020 01:31:40 -0000 > @@ -1,6 +1,7 @@ > $OpenBSD: patch-src_gui_main_cpp,v 1.2 2013/06/07 10:03:27 benoit Exp $ > ---- src/gui/main.cpp.orig Tue Jun 4 09:42:47 2013 > -+++ src/gui/main.cpp Fri Jun 7 11:01:28 2013 > +Index: src/gui/main.cpp > +--- src/gui/main.cpp.orig > ++++ src/gui/main.cpp > @@ -29,6 +29,9 @@ > * > * > @@ -9,5 +10,5 @@ $OpenBSD: patch-src_gui_main_cpp,v 1.2 2 > +#include <cstdlib> > +#endif > #include <config.h> > + #ifndef WIN32 > #include <stdlib.h> > - #include <stdio.h> > Index: patches/patch-src_samdump2_Makefile_in > =================================================================== > RCS file: patches/patch-src_samdump2_Makefile_in > diff -N patches/patch-src_samdump2_Makefile_in > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-src_samdump2_Makefile_in 29 Jan 2020 01:31:40 -0000 > @@ -0,0 +1,16 @@ > +$OpenBSD$ > + > +Fix "error: config.h: No such file or directory" on BE_ARCHS > + > +Index: src/samdump2/Makefile.in > +--- src/samdump2/Makefile.in.orig > ++++ src/samdump2/Makefile.in > +@@ -17,7 +17,7 @@ > + > + include ../common.mk > + > +-CFLAGS += -I../core > ++CFLAGS += -I../core -I../.. > + > + all: libsamdump2.a > + >
