On Fri, Jan 31, 2020 at 05:27:59PM +0100, Landry Breuil wrote: > On Fri, Jan 31, 2020 at 09:18:35AM -0700, Timothy Brown wrote: > > Hi, > > > > Thanks to Christian for pointing out a missing dependency in > > productivity/mcds. Namely security/gnupg2 as I use `gpgconf` > > when using GPGME. > > > > Please find the diff attached. I've bumped it to REVISION 0. > > > > Once again, if I've done anything incorrectly please let me know. > > If you're not linking against it, then maybe it should only be a > RUN_DEPENDS, and since configure checks for it maybe should also be a > BUILD_DEPENDS - but i'm not sure it should be a LIB_DEPENDS :) >
Thanks Landry, you're absolutely correct! Build and run it should be. Please find the updated diff. Timothy
Index: Makefile =================================================================== RCS file: /cvs/ports/productivity/mcds/Makefile,v retrieving revision 1.4 diff -u -p -r1.4 Makefile --- Makefile 17 Jan 2020 08:35:50 -0000 1.4 +++ Makefile 31 Jan 2020 17:35:10 -0000 @@ -1,10 +1,11 @@ # $OpenBSD: Makefile,v 1.4 2020/01/17 08:35:50 landry Exp $ -COMMENT = tty-based carddav search tool +COMMENT = tty-based CardDav search tool V = 1.6 DISTNAME = mcds-${V} CATEGORIES = productivity +REVISION = 0 MAINTAINER = Timothy Brown <tbr...@freeshell.org> @@ -16,10 +17,14 @@ WANTLIB = assuan c curl gpg-error gpgme MASTER_SITES = https://github.com/t-brown/mcds/releases/download/v${V}/ +BUILD_DEPENDS = security/gnupg2 + LIB_DEPENDS = devel/gettext,-runtime \ net/curl \ textproc/libxml \ security/gpgme + +RUN_DEPEBDS = security/gnupg2 CONFIGURE_STYLE = gnu