Hi,

On Mon, 3 Feb 2020 09:25:12 +0000
wen heping wrote:

> Hi, ports@:
> 
>    Here is a patch for www/p5-HTML-Scrubber:
>      i) Update to 0.19
>      ii) Remove the unneeded BUILD_DEPENDS

You just commented it :)

>      iii) Add devel/p5-Test-Memory-Cycle as TEST_DEPENDS

It's missing devel/p5-Test-Differences as well.

>    It build well and pass all tests on amd64-current system.
> 
>   Three ports depends on www/p5-HTML-Scrubber:
>     www/p5-HTML-Widget
>     www/p5-HTML-FormFu

      ^ i'm going to work on failed tests on that one, but there
        are not due to that update.

>     www/rt
>   All build well and have some failed tests, but these failed tests
> was not caused by this patch.
> 
> Cheers !
> wen
> 

Here is a diff with my above comments applied:

Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-HTML-Scrubber/Makefile,v
retrieving revision 1.10
diff -u -p -u -p -r1.10 Makefile
--- Makefile    12 Jul 2019 20:50:54 -0000      1.10
+++ Makefile    3 Feb 2020 10:04:12 -0000
@@ -4,14 +4,15 @@ COMMENT=      HTML cleaning module
 
 MODULES=       cpan
 PKG_ARCH=      *
-DISTNAME=      HTML-Scrubber-0.09
+DISTNAME=      HTML-Scrubber-0.19
 CATEGORIES=    www
-REVISION=      0
 
 # Perl
 PERMIT_PACKAGE=        Yes
 
-BUILD_DEPENDS= ${RUN_DEPENDS}
-RUN_DEPENDS=   www/p5-HTML-Parser
+RUN_DEPENDS=   www/p5-HTML-Parser>=3.47
+
+TEST_DEPENDS=  devel/p5-Test-Differences \
+               devel/p5-Test-Memory-Cycle
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/p5-HTML-Scrubber/distinfo,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 distinfo
--- distinfo    9 Mar 2013 15:30:50 -0000       1.4
+++ distinfo    3 Feb 2020 10:04:12 -0000
@@ -1,2 +1,2 @@
-SHA256 (HTML-Scrubber-0.09.tar.gz) = 
ti883SkzIhzWgEKGnnbnrfEbN7ThMKf4vP3AnN5S7G0=
-SIZE (HTML-Scrubber-0.09.tar.gz) = 26840
+SHA256 (HTML-Scrubber-0.19.tar.gz) = 
rihVePhWX5FUxj5CNHBLV7aDX3ei+C/+ckiZ1FMmK7E=
+SIZE (HTML-Scrubber-0.19.tar.gz) = 36418

Reply via email to