On Fri, Feb 21 2020, Rafael Sadowski <raf...@sizeofvoid.org> wrote: > On Fri Feb 21, 2020 at 06:17:20PM +0100, Jeremie Courreges-Anglas wrote: >> On Fri, Feb 21 2020, Rafael Sadowski <raf...@sizeofvoid.org> wrote: >> > Update tiled to 1.3.1 (Qt4 to Qt5). >> > >> > Notable changes: >> > >> > - Move to GH_* >> > - s/http/https/ >> > - Tests are no longer build. I didn't get a good look at it. tiled works >> > fine for me in a simple run-time test. >> > - Set MODPY_DEFAULT_VERSION_3 >> > >> > OK? >> >> I only played with tiles and tiled for a uni course (!) years ago, but >> figured I'd give this a try anyway. Runtime looks good after I install >> qtdeclarative, because of a missing dep on libQt5Qml.so. >> >> --8<-- >> ritchie ~$ tiled >> ld.so: tiled: can't load library 'libQt5Qml.so.2.2' >> Killed >> -->8-- >> >> --8<-- >> russell /usr/ports/editors/tiled$ make port-lib-depends-check >> >> tiled-1.3.1(editors/tiled): >> Missing lib: Qt5Qml.2 (/usr/local/bin/tiled) (NOT REACHABLE) >> *** Error 1 in target 'port-lib-depends-check' (ignored) >> -->8-- >> >> This needs adjusting, portcheck also says: >> >> missing RDEP on misc/shared-mime-info >> >> and... >> > > Thanks for the input here is a new diff which converts all your points. > I also reorder the DPB_PROPERTIES and indented GH; > > OK to nuke the creepy Qt4 stuff?
Should qtquickcontrols be added to BUILD_DEPENDS as well? Other ports using that in RUN_DEPENDS also seem to add it to BUILD_DEPENDS (though not all of them). If it's not needed, ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
