On Mon, Mar 16, 2020 at 02:57:16PM +0100, Jeremie Courreges-Anglas wrote:
> On Sun, Mar 15 2020, Klemens Nanni <k...@openbsd.org> wrote:
> > All subpackages ave a RDEP on python, so explicitness for -python is
> > redundant.
>
> -python ships a true python module, IMO it should have an rdep on python
> like other python modules in the tree. Same goes for -lldb.
Note that i'm certainly not removing the RDEP, it is already registered
through the module. I don't want to specify it twice because it is a)
redundant and b) brings other problems.
> -main ships a bunch of python scripts, but right now those scripts
> aren't properly MODPY_ADJ'd. I think it makes more sense to discuss
> removing the python rdep in this subpackage. scan-view for example is
> a python script, thankfully scan-build alone is enough.
>
> > More importantly, this uncovers how the devel/gtest RDEP has been
> > clobbered by it;
>
> The deps of the -python subpackage make sense to me as-is, without an
> explicit dependency on devel/gtest.
gtest already is an explicit RDEP for every subpackage through global
RUN_DEPENDS, but that is another story of its own as you elaborated.
> Not ok with this diff, but I'm happy with moving llvm to python3 if
> possible. I took a look some days/weeks ago, sadly I didn't note down
> why the switch wasn't straightforward. Maybe I was just busy with
> something else. Looks like a bunch of python files import __future__ so
> this looks promising.
For clarity, here are all RDEPs before
RUN_DEPENDS-main=devel/gtest lang/python/2.7
RUN_DEPENDS-python=lang/python/2.7
RUN_DEPENDS-lldb=devel/llvm,,-main lang/python/2.7 devel/py-six
and after my diff:
RUN_DEPENDS-main=devel/gtest lang/python/2.7
RUN_DEPENDS-python=devel/gtest lang/python/2.7
RUN_DEPENDS-lldb=devel/llvm,,-main lang/python/2.7 devel/py-six
Afterall, only gtest is added (and can be removed with a separate diff)
once we have more insight.
