On Sat, Feb 15, 2020 at 07:04:27PM -0800, Andrew Hewus Fresh wrote: > On Mon, Feb 03, 2020 at 02:41:45PM -0500, Chris Bennett wrote: > > On Sun, Jan 26, 2020 at 02:41:24PM -0800, Andrew Hewus Fresh wrote: > > > On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > > > > On Sun, Jan 19, 2020 at 12:57:44PM +0000, wen heping wrote: > > > > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > > > > modbuild > > > > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > > > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > > > > > > > Cheers ! > > > > > wen > > > > > > > > Attached is with the above suggestions, except that I left out the last > > > > line in the module's DESCRIPTION with the reference to look at link to a > > > > section of the DESCRIPTION in particular. > > > > > > > > I appreciate the help. Porting has changed (very much for the better) > > > > since I last did ports. > > > > > > There are extra tabs in the RUN_DEPENDS continuation, probably from > > > portgen (and I think I fixed that bug), although only a small style nit. > > > > > > After reading the DESCR, I'm fairly sure the original author is not a > > > native English speaker. Perhaps something more like: > > > > > > Plack::Request::WithEncoding is a subclass of Plack::Request that > > > supports encoded requests. It overrides many Plack::Request > > > attributes to return decoded values. > > > > > > In any case, with a fixed DESCR OK afresh1@ > > > > OK, I just used your DESCR above. I also took out the tabs in the > > RUN_DEPENDS and used multiple spaces instead. The tabs were my fault. > > I attached a new copy with both those changes. > > > OK afresh1@ > >
Better DESCR? Plack::Request::WithEncoding is a subclass of Plack::Request that supports encoded requests. It overrides many Plack::Request attributes to return decoded values. This feature allows a single application to seamlessly handle a wide variety of different language code sets. Applications that must be able to handle many different translations at once will find this extension able to quickly solve that problem. Perhaps this is a better description that points out why and when someone would find this extension useful? Otherwise, it doesn't really call out to anyone's attention who is needing to use many languages at once. Thanks -- Chris Bennett
