Tests for this failed for me:
Couldn't require Perl::Critic::Policy::Variables::ProhibitPunctuationVars :
PPIx::Regexp::Util version 0.068 required--this is only version 0.063 at
/usr/obj/ports/p5-Perl-Critic-1.138/Perl-Critic-1.138/blib/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
line 18.
On 2020/03/08 14:03, Andrew Hewus Fresh wrote:
> On Thu, Mar 05, 2020 at 02:52:27AM +0000, wen heping wrote:
> > Hi,
> >
> > Here is the revised patch:
> > i) Updated to 1.138
> > ii) Remove p5-Test-Deep from BUILD_DEPENDS
> >
> > This patch require textproc/p5-PPIx-QuoteLike, which I submitted
> > before.
> >
> > Cheers !
> > wen
>
> OK afresh1@ after the import of textproc/p5-PPIx-QuoteLike
>
>
> > ________________________________
> > 发件人: Andrew Hewus Fresh <and...@afresh1.com>
> > 发送时间: 2019年8月26日 7:23
> > 收件人: wen heping <wenheping2...@hotmail.com>
> > 抄送: ports@openbsd.org <ports@openbsd.org>
> > 主题: Re: [Update] devel/p5-Perl-Critic : update to 1.134
> >
> > On Fri, Jul 26, 2019 at 01:13:31PM +0000, wen heping wrote:
> > > Hi, ports@:
> > >
> > > Here is a patch for devel/p5-Perl-Critic:
> > > i) Update to 1.134
> > > ii) Add textproc/p5-PPIx-QuoteLike as RUN_DEPENDS, which is a new
> > > port I submitted just now.
> > > It build well and passed all tests on amd64-head system.
> > >
> > > Four ports depends on devel/p5-Perl-Critic:
> > > devel/p5-FileHandle-Unget
> > > devel/p5-Getargs-Long
> > > devel/p5-Test-Compile
> > > devel/p5-Test-Perl-Critic
> > > All build well and passed all tests on amd64-head system.
> > >
> > > Comments? OK?
> > > wen
> >
> > OK afresh1@
> >
> > (needs textproc/p5-PPIx-QuoteLike that I also OK'd imported first)
> >
> >
> > > Index: Makefile
> > > ===================================================================
> > > RCS file: /cvs/ports/devel/p5-Perl-Critic/Makefile,v
> > > retrieving revision 1.21
> > > diff -u -p -r1.21 Makefile
> > > --- Makefile 12 Jul 2019 20:45:04 -0000 1.21
> > > +++ Makefile 26 Jul 2019 13:07:51 -0000
> > > @@ -2,7 +2,7 @@
> > >
> > > COMMENT = critique Perl source code for best-practices
> > >
> > > -DISTNAME = Perl-Critic-1.126
> > > +DISTNAME = Perl-Critic-1.134
> > >
> > > CATEGORIES = devel
> > >
> > > @@ -34,7 +34,8 @@ RUN_DEPENDS = devel/p5-B-Keywords>=1.05
> > > devel/perltidy \
> > > mail/p5-Email-Address>=1.889 \
> > > sysutils/p5-File-Which \
> > > - textproc/p5-PPI>=1.220 \
> > > + textproc/p5-PPI>=1.265 \
> > > + textproc/p5-PPIx-QuoteLike \
> > > textproc/p5-PPIx-Regexp>=0.027 \
> > > textproc/p5-PPIx-Utilities>=1.001 \
> > > textproc/p5-Pod-Spell>=1
> > > Index: distinfo
> > > ===================================================================
> > > RCS file: /cvs/ports/devel/p5-Perl-Critic/distinfo,v
> > > retrieving revision 1.7
> > > diff -u -p -r1.7 distinfo
> > > --- distinfo 5 Mar 2016 15:58:05 -0000 1.7
> > > +++ distinfo 26 Jul 2019 13:07:51 -0000
> > > @@ -1,2 +1,2 @@
> > > -SHA256 (Perl-Critic-1.126.tar.gz) =
> > > saYVHLNgOu+FVRlbgH6DFlXIMAO4Hi9k//CV/3EU9a8=
> > > -SIZE (Perl-Critic-1.126.tar.gz) = 646552
> > > +SHA256 (Perl-Critic-1.134.tar.gz) =
> > > kOyH7Y1J3V/WhqDkyO93Joli+vFLGLQ/I4XbeeNAhes=
> > > +SIZE (Perl-Critic-1.134.tar.gz) = 649465
> > > Index: pkg/PLIST
> > > ===================================================================
> > > RCS file: /cvs/ports/devel/p5-Perl-Critic/pkg/PLIST,v
> > > retrieving revision 1.6
> > > diff -u -p -r1.6 PLIST
> > > --- pkg/PLIST 5 Mar 2016 15:58:05 -0000 1.6
> > > +++ pkg/PLIST 26 Jul 2019 13:07:51 -0000
> > > @@ -40,6 +40,7 @@ ${P5SITE}/Perl/Critic/Policy/BuiltinFunc
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitComplexMappings.pm
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitReverseSortBlock.pm
> > > +${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitSleepViaSelect.pm
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm
> > > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringySplit.pm
> > > @@ -80,7 +81,6 @@ ${P5SITE}/Perl/Critic/Policy/Documentati
> > > ${P5SITE}/Perl/Critic/Policy/Documentation/PodSpelling.pm
> > >
> > > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePackageMatchesPodName.pm
> > > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodAtEnd.pm
> > > -${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodLinksIncludeText.pm
> > > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodSections.pm
> > > ${P5SITE}/Perl/Critic/Policy/ErrorHandling/
> > > ${P5SITE}/Perl/Critic/Policy/ErrorHandling/RequireCarping.pm
> > > @@ -262,6 +262,7 @@ ${P5SITE}/Test/Perl/Critic/Policy.pm
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock.3p
> > > +@man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitShiftRef.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit.3p
> > > @@ -298,7 +299,6 @@ ${P5SITE}/Test/Perl/Critic/Policy.pm
> > > @man man/man3p/Perl::Critic::Policy::Documentation::PodSpelling.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName.3p
> > > @man man/man3p/Perl::Critic::Policy::Documentation::RequirePodAtEnd.3p
> > > -@man
> > > man/man3p/Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText.3p
> > > @man man/man3p/Perl::Critic::Policy::Documentation::RequirePodSections.3p
> > > @man man/man3p/Perl::Critic::Policy::ErrorHandling::RequireCarping.3p
> > > @man
> > > man/man3p/Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval.3p
> >
> >
> > --
> > andrew - http://afresh1.com
> >
> > What are the unsurpassable real world weaknesses in OpenBSD,
> > that you know of?
> > -- Kevin Chadwick <ma1l1i...@yahoo.co.uk>
> > Lots of fake people attacking the project on the mailing lists makes
> > them a poor resource for users.
> > -- Theo de Raadt <dera...@cvs.openbsd.org>
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/p5-Perl-Critic/Makefile,v
> > retrieving revision 1.21
> > diff -u -p -r1.21 Makefile
> > --- Makefile 12 Jul 2019 20:45:04 -0000 1.21
> > +++ Makefile 5 Mar 2020 02:47:29 -0000
> > @@ -2,7 +2,7 @@
> >
> > COMMENT = critique Perl source code for best-practices
> >
> > -DISTNAME = Perl-Critic-1.126
> > +DISTNAME = Perl-Critic-1.138
> >
> > CATEGORIES = devel
> >
> > @@ -18,8 +18,7 @@ TEST_DEPENDS = devel/p5-Test-Deep \
> > devel/p5-Test-Memory-Cycle
> >
> > BUILD_DEPENDS = devel/p5-B-Keywords>=1.05 \
> > - devel/p5-List-MoreUtils>=0.19 \
> > - devel/p5-Test-Deep
> > + devel/p5-List-MoreUtils>=0.19
> >
> > RUN_DEPENDS = devel/p5-B-Keywords>=1.05 \
> > devel/p5-Config-Tiny>=2 \
> > @@ -34,7 +33,8 @@ RUN_DEPENDS = devel/p5-B-Keywords>=1.05
> > devel/perltidy \
> > mail/p5-Email-Address>=1.889 \
> > sysutils/p5-File-Which \
> > - textproc/p5-PPI>=1.220 \
> > + textproc/p5-PPI>=1.265 \
> > + textproc/p5-PPIx-QuoteLike \
> > textproc/p5-PPIx-Regexp>=0.027 \
> > textproc/p5-PPIx-Utilities>=1.001 \
> > textproc/p5-Pod-Spell>=1
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/devel/p5-Perl-Critic/distinfo,v
> > retrieving revision 1.7
> > diff -u -p -r1.7 distinfo
> > --- distinfo 5 Mar 2016 15:58:05 -0000 1.7
> > +++ distinfo 5 Mar 2020 02:47:29 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (Perl-Critic-1.126.tar.gz) =
> > saYVHLNgOu+FVRlbgH6DFlXIMAO4Hi9k//CV/3EU9a8=
> > -SIZE (Perl-Critic-1.126.tar.gz) = 646552
> > +SHA256 (Perl-Critic-1.138.tar.gz) =
> > KtGU+R7yTfRpg2nCVi1BZOm/dPLVVlxoGEGr95eJ7YI=
> > +SIZE (Perl-Critic-1.138.tar.gz) = 649701
> > Index: pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/devel/p5-Perl-Critic/pkg/PLIST,v
> > retrieving revision 1.6
> > diff -u -p -r1.6 PLIST
> > --- pkg/PLIST 5 Mar 2016 15:58:05 -0000 1.6
> > +++ pkg/PLIST 5 Mar 2020 02:47:29 -0000
> > @@ -40,6 +40,7 @@ ${P5SITE}/Perl/Critic/Policy/BuiltinFunc
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitComplexMappings.pm
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitReverseSortBlock.pm
> > +${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitSleepViaSelect.pm
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm
> > ${P5SITE}/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringySplit.pm
> > @@ -80,7 +81,6 @@ ${P5SITE}/Perl/Critic/Policy/Documentati
> > ${P5SITE}/Perl/Critic/Policy/Documentation/PodSpelling.pm
> > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePackageMatchesPodName.pm
> > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodAtEnd.pm
> > -${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodLinksIncludeText.pm
> > ${P5SITE}/Perl/Critic/Policy/Documentation/RequirePodSections.pm
> > ${P5SITE}/Perl/Critic/Policy/ErrorHandling/
> > ${P5SITE}/Perl/Critic/Policy/ErrorHandling/RequireCarping.pm
> > @@ -262,6 +262,7 @@ ${P5SITE}/Test/Perl/Critic/Policy.pm
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings.3p
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr.3p
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock.3p
> > +@man man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitShiftRef.3p
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect.3p
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval.3p
> > @man
> > man/man3p/Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit.3p
> > @@ -298,7 +299,6 @@ ${P5SITE}/Test/Perl/Critic/Policy.pm
> > @man man/man3p/Perl::Critic::Policy::Documentation::PodSpelling.3p
> > @man
> > man/man3p/Perl::Critic::Policy::Documentation::RequirePackageMatchesPodName.3p
> > @man man/man3p/Perl::Critic::Policy::Documentation::RequirePodAtEnd.3p
> > -@man
> > man/man3p/Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText.3p
> > @man man/man3p/Perl::Critic::Policy::Documentation::RequirePodSections.3p
> > @man man/man3p/Perl::Critic::Policy::ErrorHandling::RequireCarping.3p
> > @man
> > man/man3p/Perl::Critic::Policy::ErrorHandling::RequireCheckingReturnValueOfEval.3p
>
>
> --
> andrew - http://afresh1.com
>
> I think I understand, but my stubborn brain refuses to admit it
> until I beat it into submission by proof upon proof.
> -- Michael Shiloh <michaelshiloh1...@gmail.com>
>
