On Tue, Apr 14, 2020 at 11:43:59AM +0100, Raf Czlonka wrote: > On Tue, Apr 14, 2020 at 10:24:47AM BST, Florian Obser wrote: > > FYI, today I updated my salt master from > > > > OpenBSD 6.6-current (GENERIC.MP) #55: Sun Mar 15 02:21:01 MDT 2020 > > > > OpenBSD 6.7-beta (GENERIC.MP) #127: Mon Apr 13 21:22:35 MDT 2020 > > > > and due to a commit to quirks I got this: > > > > py-git2-0.28.2->py3-git2-1.0.1p1: ok > > > > salt master is now of course failing: > > > > 2020-04-14 09:52:00,947 [salt.utils.gitfs > > :2541][ERROR ][62659] gitfs is configured but could not be loaded, are > > pygit2 and libgit2 installed? > > 2020-04-14 09:52:00,953 [salt.utils.gitfs > > :2478][CRITICAL][62659] No suitable gitfs provider module is installed. > > 2020-04-14 09:52:00,989 [salt.loader > > :1698][ERROR ][62659] Failed to load function git.envs because its module > > (git) is not in the whitelist: [u'gitfs'] > > 2020-04-14 09:52:00,994 [salt.utils.gitfs > > :2478][CRITICAL][62659] No suitable git_pillar provider module is installed. > > 2020-04-14 09:52:00,995 [salt.master :626 > > ][CRITICAL][62659] Failed to load git_pillar > > 2020-04-14 09:52:00,996 [salt.master :627 > > ][CRITICAL][62659] Master failed pre flight checks, exiting > > > > Turns out py-git2 was updated by jasper@ last year in December but due > > to the missing quirks commit (recently done by kn@) I still had an old > > package lying around that never got updated. > > > > As a shortterm solution I will investigate how to move away from git. > > > > Longterm I'll probably move away from salt. It causes more trouble > > than solving problems. > > > > Thanks, > > Florian > > > > Hi Florian, > > I am in the same boat - I use Salt but had to (hopefully temporarily?) > move away from using Git with it. > > It was also me who has sent the quirks diff as py-git2 is now > Python3-only so there wasn't much point in delaying this as, Salt > with Git users, we're probably in minority of pygit2 consumers. > > The couple of ways out of this that I can see is either to move to > using py-GitPython or moving Salt to Python3 (post-6.7 obviously) > - preferably the latter.
Fwiw, the salt version we have in ports is old (2018-03-03) and is already supposed to be py3-compatible (cf https://github.com/saltstack/salt/issues/11995 and https://docs.saltstack.com/en/latest/topics/releases/2017.7.0.html#python-3). And it could also be updated to more recent-ish versions.. otherwise, it's considered unmaintained, and for that kind of software its a bit sad :)
