On Fri, Apr 17, 2020 at 05:26:58PM -0600, Aaron Bieber wrote: > On Wed, 15 Apr 2020 at 18:56:09 -0600, Aaron Bieber wrote: > > On Mon, 06 Apr 2020 at 17:15:17 -0600, Aaron Bieber wrote: > > > Round two! This time with espie@'s bsd.port.mk fix: > > > https://marc.info/?l=openbsd-ports-cvs&m=158618354824687&w=2 > > > > > > This resolves the issue with the conversion of [A-Z] letters to ![a-z] in > > > the > > > package path. > > > > > > With this diff I can generate ports for the following without issue: > > > > > > github.com/jrick/domain > > > github.com/jrick/ss > > > github.com/junegunn/fzf > > > github.com/qbit/gavin > > > golang.zx2c4.com/wireguard > > > humungus.tedunangst.com/r/honk > > > suah.dev/ogvt > > > > > > There are still some issues with things like github.com/restic/restic and > > > github.com/gohugoio/hugo . For some reason the build looks for some files > > > that > > > 'go mod graph' doesn't list. > > > > > > For most go apps that follow the module guidelines: > > > https://github.com/golang/go/wiki/Modules > > > > > > This method of building things should work pretty well. One will have to > > > go in > > > and add a "do-install" to grab other files like man pages, etc. > > > > > > > OK, this fixes some issues with determining the latest version of a given > > port. > > > > With this, I can build a port for restic! (it still needs > > 'ALL_TARGET=github.com/restic/restic/...' set manually) > > > > hugo still results in some missing mod/zip files. > > > > Round... 10? > > Changes: > - Handle determine latest version in a manner that is more inline with how Go > does it. > - Error out when we are asked to gen a port for an incompatible module. > - Detect licenses from pkg.go.dev. > - Update ALL_TARGET to include "/cmd/..." when a "cmd" directory is present in > a module.
Cant comment on the portgen perl bits (afresh1@ did :), but unless someone has an opposition against it, i think it's a nice addition that can be polished in-tree if needed, as long as all existing go ports still build fine with the go.port.mk changes i dont see harm in committing it :)
