On Fri Apr 24, 2020 at 02:56:17PM +0200, Charlene Wendling wrote:
> Hi,
> 
> While looking at the macppc bulk, i've found out that we build the
> browser flavor of keepassxc on all archs.
> 
> Browser integration only works with Chromium-based browsers
> and/or Firefox [0].
> 
> As such i'm proposing to limit the build of this flavor to archs where
> these 2 browsers are built, to avoid wasting bulk time.
> 
> OK? 

fine for me.

> 
> Charlène.
> 
> 
> [0] https://keepassxc.org/docs/keepassxc-browser-migration/
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/keepassxc/Makefile,v
> retrieving revision 1.29
> diff -u -p -u -p -r1.29 Makefile
> --- Makefile  10 Apr 2020 07:25:02 -0000      1.29
> +++ Makefile  24 Apr 2020 12:19:33 -0000
> @@ -56,6 +56,8 @@ WANTLIB += yubikey ykpers-1
>  .endif
>  
>  .if ${FLAVOR:Mbrowser}
> +# Sync with archs that ship Firefox and/or Chromium
> +ONLY_FOR_ARCHS =     amd64 i386 aarch64
>  CONFIGURE_ARGS +=    -DWITH_XC_BROWSER=ON \
>                       -DWITH_XC_NETWORKING=ON
>  .endif
> 

Reply via email to