On Thu, May 14, 2020 at 10:55:09PM +1000, Arthur Barton wrote:
> Attached is a port for puppet 6.14.0. Its a minor update to the previously 
> posted 6.9.0 port.
> Confirmed working on amd64 in master-less mode.
Thanks for working on this, but a few things need fixing.

PLIST is missing lines for user creation, cleanup and special handling,
see `head pkg/PLIST' version 4 and 5 and check pkg_create(1) for what
each line does if need be.

Lots of providers and types are missing, I assume something changed
during build or fake, but this needs investigation.

Briefly tested on a masterless setup on sparc64 where Puppet 5 just works:

        Error: Evaluation Error: Error while evaluating a Resource Statement, \
        Unknown resource type: 'cron' (file: /foo/bar.pp, line: 87, column: 5) 
on node domain.tld

> .include <bsd.port.subdir.mk>
> Index: sysutils/ruby-puppet/Makefile.inc
> ===================================================================
> RCS file: /cvs/ports/sysutils/ruby-puppet/Makefile.inc,v
> retrieving revision 1.46
> diff -u -p -r1.46 Makefile.inc
> --- sysutils/ruby-puppet/Makefile.inc 12 Jul 2019 20:49:50 -0000 1.46
> +++ sysutils/ruby-puppet/Makefile.inc 14 May 2020 12:35:37 -0000
> @@ -30,6 +30,10 @@ SUBST_VARS += RUBY
> # databases/puppetdb4
> # databases/ruby-hiera3
> # sysutils/facter
Puppet 5 seems missing in this list; at least it uses facter as well.
I'd either omit this comment change from the update or take proper care
of it.

> +# Puppet 6:
> +# devel/ruby-concurrent-ruby
> +# devel/ruby-semantic_puppet
> +# sysutils/facter
> 
> MODULES += lang/ruby

Reply via email to