On Mon, May 18 2020, Alexander Bluhm <alexander.bl...@gmx.net> wrote: > Ping after unlock. > > On Mon, Apr 20, 2020 at 02:15:20AM +0200, Alexander Bluhm wrote: >> Hi, >> >> I would like to browse OPC UA servers with a python GUI. For that >> I need py-opcua, py-opcua-widgets, py-opcua-client. As py-opcua-widgets >> does not compile with python2, I think we should only have python3 >> ports. >> >> ok? >> >> Description: >> Pure Python OPC UA / IEC 62541 Client and Server Python 2, 3 and >> pypy. OPC UA binary protocol implementation is quasi complete and >> has been tested against many different OPC UA stacks. API offers >> both a low level interface to send and receive all UA defined >> structures and high level classes allowing to write a server or a >> client in a few lines. It is easy to mix high level objects and >> low level UA calls in one application. >> >> Description: >> Common widgets for opcua-modeler og opcua-client-gui. >> >> Description: >> Simple OPC-UA GUI client. Written using freeopcua python api and >> pyqt. Most needed functionnalities are implemented including >> subscribing for data changes and events, write variable values >> listing attributes and references, and call methods.
Looks good overall, here are the points I noticed: - for python3 libraries, please use FLAVORS=python3 + FLAVOR=python3 instead of MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}. This is the idiom we try to use everywhere, please apply it in py-opcua and py-opcua-widgets. Once this is done, you can update RUN_DEPENDS to use ${MODPY_FLAVOR}. - py-opcua-client looks like a pure application, please drop the "py-" prefix in the port directory name and in the PKGNAME. Note that using MODPY_VERSION=${MODPY_DEFAULT_VERSION_3} is appropriate here. - please refresh the PLISTs - py-opcua HOMEPAGE can use https:// like py-opcua-client - s/og/and/ in py-opcua-widgets/pkg/DESCR? I've been pondering importing those under misc/freeopcua, but there's probably not much to factor out in a misc/freeopcua/Makefile.inc file. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE