Le Sunday 14 Jun 2020 à 03:51 (+0200), Klemens Nanni a écrit : > On Sat, Jun 13, 2020 at 10:15:01PM +0200, Frédéric GALUSIK wrote: > > Then, it was built and tested on amd64, it needs some love on others > > platforms. > Thanks to cmake, this is relatively straight forward; only a few things > I could spot for now: > > PKGNAME defaults to DISTNAME, so the former is redundant. > > WANTLIB is incomplete, you'll want to see "make port-lib-depends-check". > > COMPILER is set correctly, however a comment is appropiate to tell *why* > such a selection is needed; here it's probably the use of -std=c++17, > so you could just add "# -std=c++17" above the COMPILER line, that's it. > > For readability, "=" is usually followed by tabs in ports Makefiles to > align the second column. > > I've done all of this in the attached tarball, thanks a lot for working > on kakoune :-)
It is noted. Thank you very much. fredg
