On Sun 05/07/2020 23:15, deserter...@danwin1210.me wrote:
> This is port consist of a fast fucking file manager, it is simply a
> bash script which does the job of copying, moving, deleting and
> navigating easier particularly for small task.
> 
> Any comments?

Hi,

Couple of comments:
- I think CATEGORIES=sysutils is better. nnn and ranger are also there.
- No need to set HOMEPAGE as this is done by the GH_* magic. Have a look
  at infrastructure/mk/bsd.port.mk. However, if fff has a homepage other
  than the one on GitHUb than you could use HOMEPAGE
- Please sort RUN_DEPENDS
- Instead of using do-install you could set FAKE_FLAGS and have Makefile
  handle the rest. Something like the line below works
  FAKE_FLAGS=DESTDIR= MANDIR="${DESTDIR}${PREFIX}/man
- No need to set CONFIGURE_STYLE as there is nothing to override

Reply via email to