On 2020/07/25 18:30, Dimitri Karamazov wrote:
> Any comments?

V=              3.0.5
DISTNAME=       zynaddsubfx-${V}

V isn't used elsewhere ->

DISTNAME=       zynaddsubfx-3.0.5



MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:=zynaddsubfx/3.0.5/}

version not needed here ->

MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:=zynaddsubfx/}



BASH_COMPLETION=${DESTDIR}${PREFIX}/share/bash_completion/completions
CONFIGURE_ARGS= -DPaEnable=ON \
                -DGuiModule=ntk \
                -DBASHCOMP_PKG_PATH=${BASH_COMPLETION} \

no need for the separate variable ->

CONFIGURE_ARGS= -DPaEnable=ON \
                -DGuiModule=ntk \
                
-DBASHCOMP_PKG_PATH=${DESTDIR}${PREFIX}/share/bash_completion/completions


post-patch:
        sed -ie "s@-w@! -d@" ${WRKSRC}/cmake/BashCompletion.cmake

post-configure:
        sed -ie "s@-lrt@@" ${WRKBUILD}/build.ninja
        sed -ie "s@\(-L${LOCALBASE}/lib\)@\1 -L${X11BASE}/lib@" \
                ${WRKBUILD}/build.ninja

just use normal patches (plus SUBST_CMD if necessary e.g. where you are
adding X11BASE) rather than seds please.

patch the input cmake file not the generated build.ninja file (don't
assume that it's using ninja to build, sometimes there are reasons to
not use this)

Reply via email to