Brian Callahan writes: > Hi Nam -- > > On Friday, July 31, 2020 7:49 PM, Nam Nguyen <n...@berkeley.edu> wrote: > >> Please find attached a new port for games/onscripter-en. >> >> onscripter-en is an English branch of onscripter to play NScripter and >> ONScripter games. These are typically visual novels. >> > > Thanks for the port. I don't have any games to test, but I did a build > test and have some thoughts:
Thank you. I attached an updated port incorporating your feedback. > > * You have that 20110628 number in both DISTNAME and PKGNAME, so it > should be spun out into its own variable (usually V). + added V > * Is there any hope for the original web page to return? If not, I > think it makes more sense to either use the kaisernet site or a > snapshot from the wayback machine (like you do in pkg/README) for > the HOMEPAGE. It seems unlikely to return. "It was abandoned in 2011, and Mion's site went offline in late 2018, resulting in many resources becoming hard to find."[0] + HOMEPAGE changed to https://web.archive.org/web/http://unclemion.com/onscripter/ + While here, MASTER_SITES changed to chaoskaiser72's mirror https://kaisernet.neocities.org/onscripter/releases/ > * For CONFIGURE_ENV, you want CC="${CC}" and CXX="${CXX}". + added CC and CXX > * Looking through the pkg/README, it seems like font/ja-sazanami-ttf > is effectively required. What do you think about adding it as an > RDEP? This sounds good. The game I was testing won't render certain glyphs like ellipsis with this font. It is still a good default font. "Sazanami Gothic is the standard-use font for most releases."[0] + Added font/ja-sazanami-ttf to RUN_DEPENDS. - Removed pkg_add from README. > * Running `make configure` it looks like there are x86(_64) specific > routines but they are not picked up because there is no test for > a platform named amd64. Something like the below will pick up amd64 > and use the x86 specific graphics routines. + While here, I added platform detection for amd64, i386 and macppc. I have only tested on amd64. With this, runtime now prints: System info: Intel CPU, with functions: MMX SSE SSE2 [0] https://kaisernet.neocities.org/onscripter/ > > ~Brian > > $OpenBSD$ > > amd64 should also match x86_64. > > Index: configure > --- configure.orig > +++ configure > @@ -291,7 +291,7 @@ esac > $echo_n " cpu type... ${nobr}" > ARCH= > case "$PLATFORM" in > -*86_64*) echo "x86_64"; ARCH=x86_64;; > +*amd64*|*86_64*) echo "x86_64"; ARCH=x86_64;; > *86*) ARCH=`expr "x$PLATFORM" : 'x\(.*86\).*'`; \ > echo "$ARCH";; > *powerpc*) echo "PowerPC"; ARCH=ppc;;
onscripter-en.tar.gz
Description: onscripter-en.tar.gz
