On Fri, Aug 07, 2020 at 10:28:43AM +0200, Stefan Hagen wrote: > Solene Rapenne wrote: > > sysutils/rofi has x11/i3 as a build dependency, it still > > compiles fine and its make test passes 14/14 > > > > ok? > > The question really is, why has rofi an i3 dependency? It is a multi > purpose launcher that doesn't need i3. I removed the dependency and > it compiles fine and tests are successful. So I propose this change: > > - remove x11/i3 dependency > - add harfbuzz to WANTLIB (was missing according to port-lib-depends-check) > > Maintainer on CC. > > ok?
i3 was needed at some point to build rofi but that's indeed no longer the case. I've applied your patch. Thanks for pointing it out. > Index: sysutils/rofi/Makefile > =================================================================== > RCS file: /cvs/ports/sysutils/rofi/Makefile,v > retrieving revision 1.30 > diff -u -p -u -p -r1.30 Makefile > --- sysutils/rofi/Makefile 8 Apr 2020 12:25:36 -0000 1.30 > +++ sysutils/rofi/Makefile 7 Aug 2020 08:25:43 -0000 > @@ -4,7 +4,7 @@ COMMENT = window switcher, run dialog a > > V = 1.5.4 > DISTNAME = rofi-${V} > -REVISION = 0 > +REVISION = 1 > > CATEGORIES = sysutils x11 > HOMEPAGE = https://github.com/davatorium/rofi > @@ -17,13 +17,12 @@ PERMIT_PACKAGE = Yes > MASTER_SITES = ${HOMEPAGE}/releases/download/${V}/ > > WANTLIB += c cairo gdk_pixbuf-2.0 gio-2.0 glib-2.0 gmodule-2.0 > -WANTLIB += gobject-2.0 intl m pango-1.0 pangocairo-1.0 pthread > -WANTLIB += rsvg-2 startup-notification-1 xcb xcb-ewmh xcb-icccm > -WANTLIB += xcb-randr xcb-render xcb-util xcb-xinerama xcb-xkb > -WANTLIB += xcb-xrm xkbcommon xkbcommon-x11 > +WANTLIB += gobject-2.0 intl m pango-1.0 pangocairo-1.0 harfbuzz > +WANTLIB += pthread rsvg-2 startup-notification-1 xcb xcb-ewmh > +WANTLIB += xcb-icccm xcb-randr xcb-render xcb-util xcb-xinerama > +WANTLIB += xcb-xkb xcb-xrm xkbcommon xkbcommon-x11 > > -BUILD_DEPENDS += devel/bison \ > - x11/i3 > +BUILD_DEPENDS += devel/bison > LIB_DEPENDS = devel/startup-notification \ > x11/gnome/librsvg \ > x11/xkbcommon > -- jasper