On Thursday, August 13, 2020 1:05 PM, Stuart Henderson <s...@spacehopper.org>
wrote:
> On 2020/08/13 16:45, Brian Callahan wrote:
>
> > Hi Stefan --
> > On Wednesday, August 12, 2020 8:10 AM, Stefan Hagen
> > sh+openbsd-po...@codevoid.de wrote:
> >
> > > Hello,
> > > I refined the port a bit.
> > >
> > > - fixed tabs
> > >
> > > - use GH_ instead of MASTER_SITE
> > >
> > > - added NO_TEST
> > > OK?
> > > Best Regards,
> > > Stefan
> > >
> >
> > Thanks for the port. Attached is an updated version that does the
> > following:
> >
> > - COMMENT should not start with a/an, so get rid of it
> > - HOMEPAGE is set from the GH_* variables, so don't need it.
> > - Tweak license marker to the slightly more accurate GPLv2 only.
> > - The patch can be simplified by using FAKE_FLAGS, so let's do that.
> > - When I tried to build this on sparc64, it failed because hsetroot
> > is using some C99 constructs. Tweak the patch to add -std=gnu99 to
> > CFLAGS.
> >
> > - Add MAKE_FLAGS=CC="${CC}".
> > - Mechanical conversion of your manual page to mdoc format, fixing
> > style errors along the way (such as new sentence = new line, add
> > formatting for email addresses, remove stray whitespace).
> > mandoc -Tlint is an excellent tool, thanks Ingo!
> >
> >
> > Build tested on amd64 and sparc64. Run tested on amd64 (I don't have
> > a glass console on sparc64).
> > OK?
> > ~Brian
>
> COMMENT = imlib2-based wallpaper changer
>
> is it interesting that it uses imlib2? I would go for something like
>
> COMMENT = wallpaper changer, works with compositors
>
> otherwise ok
Probably not interesting. Your tweak works.
~Brian
