Hi,
On Sun, Aug 02, 2020 at 09:21:06AM +0100, Laurence Tratt wrote:
> gromit-mpx-1.3.1 is now out (amongst other changes, this now warns
> when it can't grab hotkeys, as some environments like XFCE prevent
> this). Please find attached (as well as the not-changed versions of
> the companion ports).
Some comments thus far:
libindicator:
```
$ make port-lib-depends-check
libindicator-12.10.1(x11/libindicator):
Missing: c++.5 (/usr/local/libexec/indicator-loader3) (system lib)
Missing: c++abi.3 (/usr/local/libexec/indicator-loader3) (system lib)
WANTLIB += ${COMPILER_LIBCXX}
```
Some of the paths in the PLIST include what appears to be some kind of version
number (although not that of libindicator). E.g.:
include/libindicator3-0.4/*
lib/pkgconfig/indicator3-0.4.pc
It might be OK for the headers to include the version, as pkg-config could
provide the right path, but isn't it kind of annoying for consumers to have to
provide that exact version string when asking pkg-config for the flags?
```
$ pkg-config --cflags indicator3
Package indicator3 was not found in the pkg-config search path
$ pkg-config --cflags indicator3-0.4
-I/usr/local/include/libindicator3-0.4 -I/usr/local/include/gtk-3.0 ...
```
Oddly enough, libappindicator asks pkg-config for hard-coded indicator3-0.4.
libappindicator:
The same pkg-config query as above.
Also didn't build for me. Disable/fix mono support?
```
gmake[5]: Entering directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/vala/examples'
gmake[5]: Nothing to be done for 'all-am'.
gmake[5]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/vala/examples'
gmake[4]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/vala/examples'
gmake[3]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/vala'
Making all in mono
gmake[3]: Entering directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/mono'
Making all in .
gmake[4]: Entering directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/mono'
sed '/signals\[X_NEW_LABEL\] /,+6d' ../../src/app-indicator.c > app-indicator.c
sed: 1: "/signals\[X_NEW_LABEL\] ...: expected context address
gmake[4]: *** [Makefile:796: app-indicator.c] Error 1
gmake[4]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/mono'
gmake[3]: *** [Makefile:481: all-recursive] Error 1
gmake[3]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings/mono'
gmake[2]: *** [Makefile:353: all-recursive] Error 1
gmake[2]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0/bindings'
gmake[1]: *** [Makefile:409: all-recursive] Error 1
gmake[1]: Leaving directory
'/usr/local/pobj/libappindicator-12.10.0/libappindicator-12.10.0'
gmake: *** [Makefile:339: all] Error 2
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2925
'/usr/local/pobj/libappindicator-12.10.0/.build_done': @cd /usr/local/pobj/l...)
*** Error 2 in /usr/ports/x11/libappindicator
(/usr/ports/infrastructure/mk/bsd.port.mk:2584 'all':
@lock=libappindicator-12.10.0; export _...)
```
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
