On Tue, Aug 25, 2020 at 10:46 AM Sven F. <sven.falem...@gmail.com> wrote: > > On Sun, Aug 23, 2020 at 6:47 PM Andrew Hewus Fresh <and...@afresh1.com> wrote: > > > > Comments inline. > > > > On Mon, Aug 17, 2020 at 07:04:12PM -0400, Sven F. wrote: > > > Index: devel/p5-Struct-Dumb/Makefile > > > =================================================================== > > > RCS file: devel/p5-Struct-Dumb/Makefile > > > diff -N devel/p5-Struct-Dumb/Makefile > > > --- /dev/null 1 Jan 1970 00:00:00 -0000 > > > +++ devel/p5-Struct-Dumb/Makefile 17 Aug 2020 22:54:51 -0000 > > > @@ -0,0 +1,23 @@ > > > +# $OpenBSD$ > > > + > > > +COMMENT= make simple lightweight record-like structures > > > > I'm not sure if it's just the way this was submitted, but the proper > > format here is optional space, operator (= or +=), tab. Specifically, > > the character after the = (or +=) should be a tab, not a space. > > > > The optional space should be consistent in the file. > > > > > > > + > > > +MODULES= cpan > > > +CPAN_AUTHOR= PEVANS > > > +PKG_ARCH= * > > > +DISTNAME= Struct-Dumb-0.12 > > > +CATEGORIES= devel > > > > This is an odd order, The DISTNAME should be first and the others can > > either go here or down by the CONFIGURE_STYLE. No real preference on > > that, but I think it's more common for them to be down below. > > > > > > > > > +MAINTAINER= Sven <svenfalem...@gmail.com> > > > + > > > +# perl > > > +PERMIT_PACKAGE= Yes > > > + > > > +CONFIGURE_STYLE= modbuild tiny > > > > This didn't work for me, it seems to want the full modbuild, not > > the tiny version. > > > > > > > + > > > +BUILD_DEPENDS+= devel/p5-Test-Fatal > > > +TEST_DEPENDS+= devel/p5-Test-Fatal > > > > These should not be "+=" and the BUILD_DEPENDS isn't necessary, but it > > does need an additional TEST_DEPENDS on devel/p5-Data-Dump and > > devel/p5-Test-Pod though, because otherwise the test run could be > > different if that's installed. > > > > This particular module doesn't need the MAKE_ENV=TEST_POD=Yes since it > > runs the pod tests if Test::Pod is installed. > > > > > > Hello, thanks for following up, > > OK, the tabs are present in the github diff, i will use a tarball, > lets do Struct-Dumb first : > I modified the makefile (ignore spacing here) : > > ``` > # $OpenBSD$ > > COMMENT= make simple lightweight record-like structures > > DISTNAME= Struct-Dumb-0.12 > CATEGORIES= devel > CPAN_AUTHOR= PEVANS > PKG_ARCH= * > > MAINTAINER= Sven <svenfalem...@gmail.com> > > # perl > PERMIT_PACKAGE= Yes > > MODULES= cpan > MAKE_ENV= TEST_POD=Yes > CONFIGURE_STYLE= modbuild > > TEST_DEPENDS= devel/p5-Test-Fatal > > > .include <bsd.port.mk> > ``` > > Produce the package AND does not perform the testing > > ``` > ===> Configuring for p5-Struct-Dumb-0.12 > Checking prerequisites... > test_requires: > ! Test::Fatal is not installed > ``` > > I do not know if i wrote MAKE_ENV= TEST_POD=Yes wrong , > but that why i added in the line BUILD_DEPENDS with devel/p5-Test-Fatal > > Please advice :-) >
Ok, Test must be explicitly asked to work, hence it's alright. I hope this is more satisfactory -- -- --------------------------------------------------------------------------------------------------------------------- Knowing is not enough; we must apply. Willing is not enough; we must do
p5-Struct-Dumb.tar.gz
Description: GNU Zip compressed data
p5-Net-Prometheus.tar.gz
Description: GNU Zip compressed data
