On 9/9/20 6:30 PM, Omar Polo wrote:
Hi,

I found the port name interesting, so I took a look.  Some quick notes:

  - when using GH_* variables you don't need to define also MASTER_SITES

  - portcheck (/usr/ports/infrastructure/bin/portcheck) complains about
    trailing whitespaces in Makefile

  - devel/gettext,-runtime and devel/glib2 are missing as LIB_DEPENDS
    (make port-lib-depends-check complained about them), and in turns
    they also need to be added to WANTLIB.  (make port-lib-depends-check
    will help here)

  - the readme says that GCC is needed to build the bundled peg library,
    and in fact it's hardcoded.  The COMPILER should be adapted (I
    believe it should read `base-gcc ports-gcc' but I'm not 100% sure).
    Also, when it builds the peg library the CFLAGS aren't propagated, so
    the Makefile should be patched.

  - (but this is a personal opinion) I find strange that the package
    `peg-markdown' install the `markdown' executable.

other than that, it runs here :)


Hi,

All noted :-) very good points. Thanks

Here's an update with fixes applied from Stuart.

Attachment: peg-markdown.tgz
Description: Binary data

Reply via email to