On Sun, Sep 13, 2020 at 04:06:20PM +0200, Caspar Schutijser wrote:
> Hi,
>
> On Sun, Jul 26, 2020 at 01:12:49PM +0200, Caspar Schutijser wrote:
> > Below is a diff that updates sysutils/monit to 5.27.0. Tested on amd64.
> >
> > Some notes:
> >
> > 1) I added a patch to make sure the -fcf-protection=full compiler option
> > is not used. If this option is used, the compiler emits
> > .note.gnu.property ELF section headers and as a result, the produced
> > binary does not run: some garbage is printed to the screen and the
> > output ends as follows if I try to run it:
> > /usr/local/bin/monit[2]:: not found
> > /usr/local/bin/monit[2]: L: not found
> > /usr/local/bin/monit[20]: syntax error: `(' unexpected
> > I don't know if just patching away the use of this compiler option is
> > the way to go or that something else would be better. Feedback on that
> > is appreciated.
> >
> > jasper@ helped me figure out that the presence of the
> > .note.gnu.property section header was to blame, thanks for that.
> >
> > 2) I made the use of C99 explicit by appending -std=c99 to CFLAGS since
> > at least C99 is required now. Borrowed from some commits I've seen
> > from kmos@.
> >
> > 3) The tarball does not contain a README anymore so don't install it
> > in the post-install target.
>
> Apparently the .note.gnu.property stuff (bullet point #1) is not
> necessary anymore. I don't know for a fact why that is but
> my first guess would be the recent upgrade to LLVM 10.
(Should've added this bit in my previous email, sorry)
In my previous email I only talk about LLVM (and as such, the
architectures where LLVM is used). As for other architectures that use
GCC: GCC 4.2.1 does not accept the -fcf-protection=full compiler option
so on those architectures, this problem did not exist in the first
place.
Thanks,
Caspar
