On Sun, Oct 18, 2020 at 09:12:23PM -0400, Daniel Dickman wrote:
> On Thu, 15 Oct 2020, James Cook wrote:
>
> > * Paul prefers the latest version, so I stuck with 0.23.2
>
> An update would be nice, although seems like fixing the issue by just
> replacing cloudpickle could be fairly straightforward?
>
> I've attached a proof of concept which does that (while also updating to
> 0.20.4).
I tried running make test with your version (after moving things in
files one level up) and end up with
sklearn/externals/joblib/externals/cloudpickle/__init__.py:4: in <module>
from cloudpickle.cloudpickle import * # noqa
E ModuleNotFoundError: No module named 'cloudpickle'
(more complete stack trace at end). I haven't looked too deeply, but
where the old cloudpiclke/__init__.py says "from .cloudpickle import *"
the new one says
from cloudpickle.cloudpickle import * # noqa
from cloudpickle.cloudpickle_fast import CloudPickler, dumps, dump # noqa
My Python isn't good enough to know off the top of my head what's going
on, but if I have time later I can dig deeper.
> > even though it requires new ports.
>
> what are the new ports? happy to work with you to try to get those in.
I think the only new direct dependency is the threadpoolctl Python
library, but that depends in turn on "flit" and "pytest-cov" which I
don't see in ports. I haven't checked whether those have yet more
dependencies that aren't in ports.
https://github.com/joblib/threadpoolctl/blob/master/dev-requirements.txt
> > * I don't know what the WANTLIB line does but copied it from Daniel's
> > patch in case it's important.
>
> "make port-lib-depends-check" shows these may be needed.
>
> see the porting checklist in the porting guide. (item #26)
Thanks; I will take a look if I find more time for this (possibly
tomorrow).
--
James