???? ???????:
> Hello,
>
> I analyzed postfix using cppcheck and I would like to submit patches.
> how can I do that ?
In this case, please don't waste yor time. The first "error" that
I examined is totally bogus.
> [src/posttls-finger/posttls-finger.c:878]: (warning) Redundant assignment
> of 'stream' to itself.
The source code in question is:
876 TLS_CLIENT_START(&start_props,
877 ctx = state->tls_ctx,
878 stream = stream,
After macro expansion, this becomes the equivalent of:
tls_client_start(
(&start_props)->ctx = state->tls_ctx,
(&start_props)->stream = stream,
This proves that cppcheck is a naive program that analyzes code
without expanding macros.
This is literally multiple decades behind the more advanced static
analyzers such as Coverity and Beam that have been used on Postfix.
Wietse
