I have compiled the new version, but it has an extra “#endif” in dict_redis.h
Looking at dict_mysql.c it looks like it is missing “#ifdef SNAPSHOT” in dict_redis.h Duncan > On 13 Mar 2021, at 22:58, Dunk <d...@denkimushi.com> wrote: > > Thanks very much, I will have a look. > > I can look at the TODOs. I am more familiar with how it works now, but need > to understand the memcache code as well. > > Duncan > >> On 13 Mar 2021, at 22:34, Wietse Venema <wie...@porcupine.org> wrote: >> >> Wietse Venema: >>> Dunk: >>>> Thanks, I have tested in on a low volume email server. >>> >>> Wietse Venema: >>>> The code is pretty clean, so I expect no surprises. I noticed that >>> >>> I have cleaned up the docs and code a little, and discovered that >>> the query interface does not support the query formatting and domain >>> matching features of the ldap, *sql* and memcache clients. >>> >>> This could (should) be similar to the memcache client implementation, >>> including the key_format feature. >>> >>> I can do that but it will take some time, and it is unlikley to be >>> part of the upcoming Postfix 3.6 release. >> >> Attached is an updated patch, with some TODOs. I can implement >> those, that but it will take some time. >> >> Wietse >> <redis-patch.txt>