Tomas Korbar via Postfix-devel:
> Hi guys,
> I am continuing in this thread since it's related to the SRV resolution
> feature.
> During incorporation of this feature to Fedora and RHEL, static analysis
> found some
> minor flaws that I want to report and propose addressing them.
>
> There is an unnecessary double check of the "addr_list" pointer for null
(twice). It does no harm, and a good compiler will remove that test.
Generally, I don't worry about repeated tests like this. They make
Postfix code a bit easier to maintain, because there are fewer
implicit dependencies.
> In posttls-finger there are problems with using "service" char pointer in
> logging. I initialized the variable
> to null and ensured that it does not point into already freed space.
Yeah, that is the result of clumsy memory management and should be fixed.
I'll try to make this more obviously correct without adding multiple
instances of "if (bah != 0) myfree(bah);" throughout the code,
because it's too easy to forget adding another instance when the
code is updated.
Wietse
_______________________________________________
Postfix-devel mailing list -- postfix-devel@postfix.org
To unsubscribe send an email to postfix-devel-le...@postfix.org
