Good job, and thanks for adding tests.
A few comments:
- I was surprised that it takes a non-trivial amount of code to
basically raise the DICT_DEBUG flag on a dictionary instance. But
I guess that is because the debug: monitor is now also installed
as a dictionary.
- It handles recursion robustly:
$ postmap -q root debug:debug:unix:passwd.byname
postmap: unix:passwd.byname lookup: "root" = "root:x:0:0:Super
User:/root:/bin/bash"
postmap: debug:unix:passwd.byname lookup: "root" = "root:x:0:0:Super
User:/root:/bin/bash"
root:x:0:0:Super User:/root:/bin/bash
- postconf_dbms.c needs to be updated to skip leading debug: prefixes
just like proxy: prefixes. The purpose of that module is to
inspect database-specific config files (LDAP, SQL, etc.), and
to complain about mistakes with database client parameter settings.
- Need to add ${SHLIB_ENV} before ${VALGRIND} in tests, so that
they will work when Postfix is built with shared libpostfix-*
libraries.
Wietse
_______________________________________________
Postfix-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
