> -----Original Message----- > From: Arjan van de Ven [mailto:ar...@linux.intel.com] > Sent: Monday, March 12, 2012 8:04 PM > To: Mathew, John > Cc: power@bughost.org > Subject: Re: [PATCH] Add support for new power traces > > On 3/12/2012 10:56 AM, John Mathew wrote: > > kernel > > documentation events-power.txt for details. > > > > Inorder to allow backward compatiblity the functionality > > of this patch has been done under a macro NEW_POWER_TRACE_APIS. > > When using a kernel version greater than 2.6.41 uncomment > > the macro in main.cpp > > > while I don't mind support for the new points... > > ... I do mind this being done as a compile time thing with ifdefs. > > why not just always support these trace points ?
I saw code which was using both the old and new version of trace points. In case of such code, the measurements would be wrong. I can re-submit the patch without the macros and expect the developers to use any one version of the trace apis. --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Power mailing list Power@bughost.org https://bughost.org/mailman/listinfo/power
