On (04/27/12 17:50), Arjan van de Ven wrote:
> On 4/27/2012 4:19 PM, Mike Frysinger wrote:
> > On Friday 27 April 2012 16:43:11 Arjan van de Ven wrote:
> >> On 4/27/2012 1:44 PM, Mike Frysinger wrote:
> >>> On Friday 27 April 2012 16:34:53 Sergey Senozhatsky wrote:
> >>>> iw: handle HAVE_LIBNL20 properly
> >>>>
> >>>> Move HAVE_CONFIG_H and config.h inclusion to iw header file, which is
> >>>> the right place for HAVE_LIBNL20 dependent `define nl_sock nl_handle'.
> >>>
> >>> glancing through the libnl headers, it seems we don't even need to manage
> >>> HAVE_LIBNL20 in autoconf. we can include netlink/version.h and key off
> >>> of LIBNL_VER_MAJ.
> >>
> >> one thing to note is that the iw.c code is borrowed from elsewhere...
> >>
> >> the more we deviate, the harder it will be to follow the other code
> >> (not that we needed to so far)
> >
> > hmm, no biggie. the file is small, and my suggestion isn't critical, so
> > keeping current stuff is ok.
>
> if we're really improving it we should send the patches also to the
> maintainer at least..
>
Hello,
We still need this patch to be applied (or workaround).
There is a
#ifndef CONFIG_LIBNL20
# define nl_sock nl_handle
#endif
in iw.h, which depends on LIBNL20 config option.
tuning/iw.c: In function ‘nl80211_init’:
tuning/iw.c:86:17: warning: assignment from incompatible pointer type [enabled
by default]
tuning/iw.c:92:2: warning: passing argument 1 of ‘genl_connect’ from
incompatible pointer type [enabled by default]
In file included from tuning/iw.c:42:0:
/usr/include/libnl3/netlink/genl/genl.h:23:13: note: expected ‘struct nl_sock
*’ but argument is of type ‘struct nl_handle *’
tuning/iw.c:98:2: warning: passing argument 1 of ‘genl_ctrl_alloc_cache’ from
incompatible pointer type [enabled by default]
In file included from tuning/iw.c:44:0:
/usr/include/libnl3/netlink/genl/ctrl.h:25:14: note: expected ‘struct nl_sock
*’ but argument is of type ‘struct nl_handle *’
tuning/iw.c:115:2: warning: passing argument 1 of ‘nl_socket_free’ from
incompatible pointer type [enabled by default]
In file included from /usr/include/libnl3/netlink/netlink.h:33:0,
from /usr/include/libnl3/netlink/genl/genl.h:15,
from tuning/iw.c:42:
/usr/include/libnl3/netlink/socket.h:24:14: note: expected ‘struct nl_sock *’
but argument is of type ‘struct nl_handle *’
tuning/iw.c: In function ‘nl80211_cleanup’:
tuning/iw.c:123:2: warning: passing argument 1 of ‘nl_socket_free’ from
incompatible pointer type [enabled by default]
In file included from /usr/include/libnl3/netlink/netlink.h:33:0,
from /usr/include/libnl3/netlink/genl/genl.h:15,
from tuning/iw.c:42:
/usr/include/libnl3/netlink/socket.h:24:14: note: expected ‘struct nl_sock *’
but argument is of type ‘struct nl_handle *’
tuning/iw.c: In function ‘__handle_cmd’:
tuning/iw.c:246:2: warning: passing argument 1 of ‘nl_send_auto_complete’ from
incompatible pointer type [enabled by default]
In file included from /usr/include/libnl3/netlink/genl/genl.h:15:0,
from tuning/iw.c:42:
/usr/include/libnl3/netlink/netlink.h:62:14: note: expected ‘struct nl_sock *’
but argument is of type ‘struct nl_handle *’
tuning/iw.c:257:3: warning: passing argument 1 of ‘nl_recvmsgs’ from
incompatible pointer type [enabled by default]
In file included from /usr/include/libnl3/netlink/genl/genl.h:15:0,
from tuning/iw.c:42:
/usr/include/libnl3/netlink/netlink.h:73:14: note: expected ‘struct nl_sock *’
but argument is of type ‘struct nl_handle *’
-ss
_______________________________________________
Power mailing list
Power@bughost.org
https://bughost.org/mailman/listinfo/power
