On Sun, Feb 26, 2006 at 11:40:07AM +0100, Stefan Seyfried wrote:
> On Sun, Feb 26, 2006 at 01:23:25AM +0100, Michael Biebl wrote:
> > Hi,
> > 
> > this is a followup to [1]. As it seems powersaved does not call hdparm
> > on SATA disks. exec_hdparm() in
> > /usr/lib/powersave/scripts/set_disk_settings only handles ide bus type
> > hard disks. As SATA disks will appear as scsi disks they will be skipped
> > here. Maybe it would be a good idea to add support for SATA disks as
> > they are becoming increasingly popular.
> 
> I think exec_hdparm() no longer does have this limitation by itself,

OOPS. I should know my own code better. It still does...

> however, it calls get_disk_aam_apm() to check if the disk actually
> supports APM and AAM (and this is actually necessary, as i had to
> learn - i have a seagate ST960812A here that does not support AAM;
> if you try to enable it anyway it locks up the bus for some seconds
> until the IDE driver issues a bus reset) and get_disk_aam_apm uses
> /proc/ide/$DEV/identify to check the capability bits.

But this is still true. We could of course do a "force" parameter, that
would skip the get_disk_aam_apm() call.
Sigh - yet another configuration variable :-) I'll think about it.
-- 
Stefan Seyfried                  \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices      \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \                    -- Leonard Cohen
_______________________________________________
powersave-devel mailing list
powersave-devel@forge.novell.com
http://forge.novell.com/mailman/listinfo/powersave-devel

Reply via email to