On Mar 7, 2013, at 12:50 PM, Saul St. John wrote: > I sent you a pull request on github, instead. I think it addresses all > of feedback, except: >> >> I suspect these unpacks are broken; again this is my fault. Have you tested >> them? Attached is an untested patch which I think fixes them for reg load >> (or at least gets closer). > Nope, I didn't test them at all! I was suspicious too, but this > functionality isn't useful to me, so I just made superficial > modifications to the implementation copied from nx_reg_load.
I pulled the PR, wrote some tests for openflow.nicira, and fixed a bunch of bugs including these unpacks which were in fact bad. Thanks for the contribution. :) -- Murphy
