Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204955043
  
    --- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
    @@ -66,7 +66,7 @@
         private final LogReplicaSet replicas = new LogReplicaSet();
     
         // The transaction records, this set must be ORDER PRESERVING
    -    private final LinkedHashSet<LogRecord> records = new LinkedHashSet<>();
    +    private final Set<LogRecord> records = Collections.synchronizedSet(new 
LinkedHashSet<>()); // TODO: Hack until we fix CASSANDRA-14554
    --- End diff --
    
    I should've worded the comment differently but it is a hack to avoid a 
`ConcurrentModificationException` 
([CASSANDRA-14554](https://issues.apache.org/jira/browse/CASSANDRA-14554)). 
This currently exists in trunk and was not introduced as part of this PR hence 
the separate ticket.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to