bowensong commented on a change in pull request #1220:
URL: https://github.com/apache/cassandra/pull/1220#discussion_r721758162
##########
File path: bin/cqlsh.py
##########
@@ -2107,16 +2117,47 @@ def should_use_color():
return True
+def is_file_secure(filename):
+ if is_win:
+ # We simply cannot tell whether the file is seucre on Windows,
Review comment:
I think that notification will persistently hunt all Windows CQLSH users
and can be a source of annoyance for many. I would rather try to think about
the bright side, Windows is rarely used in multi-user environments, and file
ownership and permission usually aren't a concern on such system. In case a
Windows machine is shared between multiple users, it's extremely likely all
users (and future users) would have physical access to the machine. File
ownership and permission are much less of a concern if the physical security of
the machine simply cannot be guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
