smiklosovic commented on a change in pull request #1229:
URL: https://github.com/apache/cassandra/pull/1229#discussion_r726063447
##########
File path: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java
##########
@@ -154,7 +154,7 @@ private SystemDistributedKeyspace()
public static KeyspaceMetadata metadata()
{
- return
KeyspaceMetadata.create(SchemaConstants.DISTRIBUTED_KEYSPACE_NAME,
KeyspaceParams.simple(3), Tables.of(RepairHistory, ParentRepairHistory,
ViewBuildStatus));
+ return
KeyspaceMetadata.create(SchemaConstants.DISTRIBUTED_KEYSPACE_NAME,
KeyspaceParams.simple(Math.max(3, DatabaseDescriptor.getDefaultKeyspaceRF())),
Tables.of(RepairHistory, ParentRepairHistory, ViewBuildStatus));
Review comment:
could you please extract "3" here in the Math.max mehod into a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
