Maxwell-Guo commented on code in PR #2894:
URL: https://github.com/apache/cassandra/pull/2894#discussion_r1404003214
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1415,6 +1426,52 @@ public static void applyPartitioner(Config conf)
paritionerName = partitioner.getClass().getCanonicalName();
}
+ private static DiskAccessMode
resolveCommitLogWriteDiskAccessMode(DiskAccessMode providedDiskAccessMode)
+ {
+ boolean compressOrEncrypt = getCommitLogCompression() != null ||
(getEncryptionContext() != null && getEncryptionContext().isEnabled());
+ boolean directIOSupported = false;
+ try
+ {
+ directIOSupported = FileUtils.getBlockSize(new
File(getCommitLogLocation())) > 0;
Review Comment:
Sorry, because I saw the variable name is directIOSupported, I simply
thought this was to determine whether directIO is supported. So do you think
is it necessary to modify the variable name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
