smiklosovic commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1418668760
##########
src/java/org/apache/cassandra/db/ReadCommand.java:
##########
@@ -425,11 +425,14 @@ public UnfilteredPartitionIterator
executeLocally(ReadExecutionController execut
.collect(Collectors.joining(",")));
}
- UnfilteredPartitionIterator iterator = (null == searcher) ?
queryStorage(cfs, executionController) : searcher.search(executionController);
Review Comment:
I think that this should be moved inside `try` because if we get iterator
and then it will throw in `RTBoundValidator.validate` then such iterator is
never closed. Might happen ... right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
