belliottsmith commented on code in PR #77:
URL: https://github.com/apache/cassandra-accord/pull/77#discussion_r1418896213
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -191,6 +191,11 @@ public Durability get(TxnId txnId, RoutingKey participant)
return entry == null ? NotDurable : entry.get(txnId);
}
+ public boolean isUniversal(TxnId txnId)
+ {
+ return min(txnId) == UniversalOrInvalidated;
Review Comment:
This class never returns `Universal` because it cannot make such a
guarantee. It only has summary information, so it only knows that one or the
other happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
