5 commented on code in PR #81:
URL: https://github.com/apache/cassandra-sidecar/pull/81#discussion_r1468183927
##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -63,13 +64,15 @@ public SidecarClient(SidecarInstancesProvider
instancesProvider,
RetryPolicy defaultRetryPolicy)
{
this.defaultRetryPolicy = defaultRetryPolicy;
- ignoreConflictRetryPolicy = new
IgnoreConflictRetryPolicy(sidecarClientConfig.maxRetries(),
-
sidecarClientConfig.retryDelayMillis(),
-
sidecarClientConfig.maxRetryDelayMillis());
- baseBuilder = new RequestContext.Builder()
- .instanceSelectionPolicy(new
RandomInstanceSelectionPolicy(instancesProvider))
- .retryPolicy(defaultRetryPolicy);
- executor = requestExecutor;
+ this.ignoreConflictRetryPolicy = new
IgnoreConflictRetryPolicy(sidecarClientConfig.maxRetries(),
+
sidecarClientConfig.retryDelayMillis(),
+
sidecarClientConfig.maxRetryDelayMillis());
+ this.oncePerInstanceRetryPolicy = new
OncePerInstanceRetryPolicy(sidecarClientConfig.minimumHealthRetryDelay(),
+
sidecarClientConfig.maximumHealthRetryDelay());
+ this.baseBuilder = new RequestContext.Builder()
+ .instanceSelectionPolicy(new
RandomInstanceSelectionPolicy(instancesProvider))
+ .retryPolicy(defaultRetryPolicy);
Review Comment:
Removed optional `this.`es, changed indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
