Maxwell-Guo commented on code in PR #2879:
URL: https://github.com/apache/cassandra/pull/2879#discussion_r1535026413
##########
src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java:
##########
@@ -99,24 +106,26 @@ private IndexSummaryManager(Supplier<List<T>>
indexSummariesProvider)
this.indexSummariesProvider = indexSummariesProvider;
executor = executorFactory().scheduled(false, "IndexSummaryManager",
Thread.MIN_PRIORITY);
-
- long indexSummarySizeInMB =
DatabaseDescriptor.getIndexSummaryCapacityInMiB();
- int interval =
DatabaseDescriptor.getIndexSummaryResizeIntervalInMinutes();
+ // TODO make format get from default format
+ format = DatabaseDescriptor.getSelectedSSTableFormat();
Review Comment:
Hi @blambov， long time no see, and I am back and continue working on this
again. After previous communication with you above , I already have some clear
directions for modifying this patch .
But I have a new question about table level configuration of
[CASSANDRA-18534](https://issues.apache.org/jira/browse/CASSANDRA-18534) .
the discussion in
[CASSANDRA-18441](https://issues.apache.org/jira/browse/CASSANDRA-18441) has
described that we will not support per-table configuration at this point ,
right ? so , that means we may only have two kinds of sstable format: big or
bti. And there is not going to support the feature that contains more than two
kinds of sstable format configuration
[here](https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1114),
as I have said may be big/bti/big-small/bti-small and so on ? Am I right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
