tolbertam commented on code in PR #1801:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1801#discussion_r1728387648
##########
conn.go:
##########
@@ -43,25 +43,11 @@ import (
"github.com/gocql/gocql/internal/streams"
)
-var (
- defaultApprovedAuthenticators = []string{
- "org.apache.cassandra.auth.PasswordAuthenticator",
- "com.instaclustr.cassandra.auth.SharedSecretAuthenticator",
- "com.datastax.bdp.cassandra.auth.DseAuthenticator",
- "io.aiven.cassandra.auth.AivenAuthenticator",
-
"com.ericsson.bss.cassandra.ecaudit.auth.AuditPasswordAuthenticator",
- "com.amazon.helenus.auth.HelenusAuthenticator",
- "com.ericsson.bss.cassandra.ecaudit.auth.AuditAuthenticator",
- "com.scylladb.auth.SaslauthdAuthenticator",
- "com.scylladb.auth.TransitionalAuthenticator",
-
"com.instaclustr.cassandra.auth.InstaclustrPasswordAuthenticator",
- }
-)
-
-// approve the authenticator with the list of allowed authenticators or
default list if approvedAuthenticators is empty.
+// approve the authenticator with the list of allowed authenticators. If the
provided list is empty,
+// the given authenticator is allowed.
func approve(authenticator string, approvedAuthenticators []string) bool {
if len(approvedAuthenticators) == 0 {
Review Comment:
alternatively, could test for nil, but felt would keep it this way for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
