ifesdjeen commented on code in PR #3493:
URL: https://github.com/apache/cassandra/pull/3493#discussion_r1732363139
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -625,12 +630,18 @@ private static int msVersion(int version)
* Handling topology changes / epoch shift
*/
- private final class DelayedRequestProcessor extends Thread
+ private class DelayedRequestProcessor implements Interruptible.Task
{
private final ManyToOneConcurrentLinkedQueue<RequestContext>
delayedRequests = new ManyToOneConcurrentLinkedQueue<>();
private final LongArrayList waitForEpochs = new LongArrayList();
private final Long2ObjectHashMap<List<RequestContext>> byEpoch = new
Long2ObjectHashMap<>();
private final AtomicReference<Condition> signal = new
AtomicReference<>(Condition.newOneTimeCondition());
+ private Interruptible executor;
Review Comment:
From what I understand, we only need happens-before, so probably the only
scenario where this could happen is something like a CTRL-C, but then I am not
sure if we would even shutdown the node properly. But I do not mind adding
this. Would be great to be able to have an executor with a delayed start though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
