michaelsembwever commented on code in PR #3526:
URL: https://github.com/apache/cassandra/pull/3526#discussion_r1758623184


##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -6077,6 +6118,36 @@ public void 
setNativeTransportMaxConcurrentRequestsInBytesPerIp(long newLimit)
         ClientResourceLimits.setEndpointLimit(newLimit);
     }
 
+    public boolean isOutOfTokenRangeRequestLoggingEnabled()
+    {
+        return DatabaseDescriptor.getLogOutOfTokenRangeRequests();
+    }

Review Comment:
   nit: what's the purpose of this method (and 
`isOutOfTokenRangeRequestRejectionEnabled()`), instead of just using  
`DatabaseDescriptor.getLogOutOfTokenRangeRequests()` directly ? 
   
   (it a lot of places I would think it makes more sense for those locations to 
be package-coupling against .conf instead of .service, even if StorageService 
is already used everywhere…)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to