belliottsmith commented on code in PR #121:
URL: https://github.com/apache/cassandra-accord/pull/121#discussion_r1764779768
##########
accord-core/src/test/java/accord/impl/basic/Cluster.java:
##########
@@ -219,18 +220,50 @@ public void processAll()
processNext(next);
}
+ boolean hasNonRecurring()
+ {
+ boolean hasNonRecurring = false;
+ for (Pending p : pending)
+ {
+ if (!(p instanceof RecurringPendingRunnable))
+ continue;
+ RecurringPendingRunnable r = (RecurringPendingRunnable) p;
+ if (r.requeue.hasNonRecurring())
+ {
+ hasNonRecurring = true;
+ break;
+ }
+ }
+
+ return hasNonRecurring;
+ }
+
public boolean processPending()
{
checkFailures.run();
- if (pending.size() == recurring)
+ // All remaining tasks are recurring
+ if (recurring > 0 && pending.size() == recurring && !hasNonRecurring())
return false;
- Object next = pending.poll();
+ Pending next = pending.poll();
if (next == null)
return false;
processNext(next);
+
checkFailures.run();
+
+ // If drain was requested, run until we have no non-recurring tasks
are available
+ if (next instanceof RecurringPendingRunnable &&
((RecurringPendingRunnable) next).drainAfterRunning)
Review Comment:
by which I mean, instead of making the recurring task say "drain after me",
the task submits a one-shot drain task whenever it wants to perform a drain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
