maedhroz commented on code in PR #3645:
URL: https://github.com/apache/cassandra/pull/3645#discussion_r1825220657
##########
src/java/org/apache/cassandra/index/sai/plan/Expression.java:
##########
@@ -236,6 +239,16 @@ public Expression add(Operator op, ByteBuffer value)
lower = new Bound(value, indexTermType, true);
upper = lower;
break;
+
+ case IN:
+ if (indexTermType.isValid(value))
Review Comment:
This might pass for the string case, but I don't think we want to pass the
`value` BB directly to `isValid()`. I think you would need to do something
similar to what you've done in `termMatches()` to get the individual items and
pass those. Having said that, I'm not sure we need to validate here at all if
we'll fail somewhere further up the stack with invalid `IN` values. If we avoid
validation, we can also just reuse the `EQ`/`CONTAINS`/`CONTAINS KEY` block
above...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
