michaelsembwever commented on code in PR #282: URL: https://github.com/apache/cassandra-website/pull/282#discussion_r1829531910
########## site-content/source/modules/ROOT/pages/native_protocol.adoc: ########## @@ -3,21 +3,81 @@ == Native Protocol Version 3 -[source, plaintext] ----- -include::example$TEXT/native_protocol_v3.spec[Version 3] ----- +[source, js] +++++ +<div id="contentv3" class="doc-container"></div> +<iframe id="iframev3" src="native_protocol_v3.html" style="display:none;"></iframe> Review Comment: Also… there's another thing we might be cleaned up here. The native protocol spec files are actually here: https://github.com/apache/cassandra/tree/trunk/doc They're the source of truth, and those that will be kept up to date. IUUC the ones in cassandra-website and unnecessary duplicates: https://github.com/apache/cassandra-website/tree/trunk/site-content/source/modules/ROOT/examples/TEXT We can assume that these from apache/cassandra:trunk are accurate. And delete the `examples/TEXT` directory. And it might be possible then to not need any gitignore addition. An alternative here would be to also remove the native_protocol.adoc file from casandra-website altogether, creating this file instead here: https://github.com/apache/cassandra/tree/trunk/doc/modules/cassandra/pages (this would mean running `process-native-protocol-specs-in-docker.sh` on each `generate_cassandra_versioned_docs()`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
