maedhroz commented on code in PR #3645:
URL: https://github.com/apache/cassandra/pull/3645#discussion_r1836970975
##########
src/java/org/apache/cassandra/index/sai/plan/Expression.java:
##########
@@ -169,6 +172,7 @@ public Expression add(Operator op, ByteBuffer value)
case EQ:
case CONTAINS:
case CONTAINS_KEY:
+ case IN:
Review Comment:
Yeah, because `isEquality()` is used when we actually hit the index, it
doesn't matter right now. However, it would probably make sense to add it,
because if we ever do support it at the index level, we'll need it. @sunil9977
Does that make sense? I don't think it actually breaks anything in the
meantime...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]