dcapwell commented on code in PR #3679:
URL: https://github.com/apache/cassandra/pull/3679#discussion_r1847081580
##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommandStore.java:
##########
@@ -156,12 +158,12 @@ public PreLoadContext canExecute(PreLoadContext context)
}
if (unavailable == null)
- return context;
+ return with;
if (unavailable.size() == keys.size())
return null;
- return PreLoadContext.contextFor(context.primaryTxnId(),
context.additionalTxnId(),
keys.without(RoutingKeys.ofSortedUnique(unavailable)), keyHistory);
+ return PreLoadContext.contextFor(with.primaryTxnId(),
with.additionalTxnId(), keys.without(RoutingKeys.ofSortedUnique(unavailable)),
keyHistory);
Review Comment:
this is going to conflict with your other patch, but looks fine from this
patches point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
