bdeggleston commented on code in PR #3663:
URL: https://github.com/apache/cassandra/pull/3663#discussion_r1849192511
##########
src/java/org/apache/cassandra/db/Mutation.java:
##########
@@ -150,6 +150,11 @@ public ImmutableCollection<PartitionUpdate>
getPartitionUpdates()
return modifications.values();
}
+ public long getApproxCreatedAtNanos()
+ {
+ return approxCreatedAtNanos;
Review Comment:
`ModificationStatement#executeWithoutCondition` creates the write/delete
timestamps before the mutations themselves are created. This means that hints
could still be delivered late if enough time passes after creating the
timestamps.
This should err on the side of discarding hints early, so we should be
recording a timestamp before actually creating mutation timestamps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
